bug: Hail panel does not preserve animation attributes

[tibetiroka]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Animated sprites lose their animation attributes in the hail panel, leading to unpredictable behaviour.

Steps to Reproduce

I recommend using Omnis to see planets with animated sprites, since there aren't any in vanilla afaik.

1. Go to the arena planets
2. Hail the planet and look at the icon

Expected Behavior

The panel should preserve the animation.

Operating System

EndeavourOS (kernel: Linux 6.7.3-zen1-1-zen)

Game Source

Built from source

Game Version

d123014

Additional Information

No response

[Amazinite]

The planet itself doesn't do the full animation cycle; frames seem to follow each other much slower than in regular sprites, and then jerk back to the starting position without finishing the animation

Are you using the same animation attributes? The jerking sounds like you're not using "rewind", and the slow behavior sounds like the frame rate is just low.

[warp-core]

		"frame rate" 14.3
		"random start frame"
		rewind

Add these as children of the sprite in the object definition.

In the planet dialog thingy, the animation is really fast. Like, really, really fast.

Is "planet dialog thingy" the hail panel?

[Saugia]

If not given a frame rate, animated sprites default to 2/60 (in the code). None of the Omnis planets have a defined framerate which is why they look strange in their animations.

[alexrovw]

It is indeed pretty weird in the planetary hail window. I don't see any issues on the normal space view, though.

Screen.Recording.2024-02-04.at.1.02.42.PM.mov

[tibetiroka]

Oh. It is using the wrong framerate/rewind, but that still does not explain why it looks different in the popup panel from the planet itself.

[Amazinite]

The hail panel is losing the animation properties of the stellar object.

[tibetiroka]

Does that mean it affects animated ship sprites as well as planet sprites?

[Saugia]

Considering the Void Sprites as an example don't bug out when targeting them, or Archons, that's different, no?

Actually, animated ships in their hail panels don't even animate.

[tibetiroka]

What a clever workaround.