-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I don't feel part of pull request #9399 is a bug #9996
Comments
I don't think it makes much sense that Delta V and Kraz basics are sold so far away from their home regions, especially when it doesn't occur elsewhere. How extensive would you like the changes to be, in regards to the new outfitter idea? I was thinking of at least a conversation talking about it. Conversations relating to the consequences of the nuclear bombings are incredibly scarce. I'm happy to write something up and PR it, I only said that "it wasn't picked up on by the developers" before because of Amazinite's reaction in the original PR. The bottom line for me is that, if a differentiation in outfit stocks can be explained somewhere (e.g. a conversation), that would not only justify the inclusion but add some more life to the game where there was none before. Whereas before it appeared to be a mistake. (P.S. Submitting an issue is probably the right thing to do; closed PRs are harder to track.) |
Perhaps something like this:
Still working on it, but that's a potential PR. |
@43897689431805741092 Do you have any thoughts now that #10021 has been merged? |
Closed by #10021. |
You asked me elsewhere and I'm happy with what you'd done! Just saying for the public record of this game's open-source development. One thought I had but didn't share at the time was that I'd like to see the Greyhound and Impala plasma engines still available, or at least the Greyhound ones since these also appear in the Core region under the Syndicate Advanced sales. The single most common case for me outfitting on New China has been "I want plasma engines on my freighters because they aren't using their battery reserves to power anything else 80% of the time", and that seems like a sentiment many merchants in-universe might share – the Bulk Freighter is noted as being painfully slow to align itself for hyperjumps, so plasma steering engines would be a perfect inexpensive aftermarket refit for it. |
Problem Description
See: #9939 (comment)
Sorry if making an Issue of this is not appropriate but since the PR has been merged and realistically very few people are going to read the comments after that fact(?), this seems like what I am supposed to do(?).
Related Issue Links
#9939
Desired Solution
Reversion of part of the PR's changes:
remove outfitter "Lovelace Basics"
remove outfitter "Syndicate Basics"
add outfitter "Delta V Basics"
add outfitter "Kraz Basics"
Alternative Approaches
Bene-dictator did say "I did mention making a small, regional outfitter for the area around New China, though it wasn't picked up on by the developers. I do feel like there could be a way to tie it to the civil war – maybe the regional outfitters being selling sensor equipment in response to growing tensions and merchants' desires to protect themselves from piracy."
I don't think that would make me happy without more extensive changes that may be beyond the scope of this Issue that actually do "tie it to the civil war", but that's worth considering as it doesn't appear to have been.
Additional Context
No response
The text was updated successfully, but these errors were encountered: