Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app parameters should be copied to runConfig #2

Open
jonboulle opened this issue Feb 9, 2015 · 1 comment
Open

app parameters should be copied to runConfig #2

jonboulle opened this issue Feb 9, 2015 · 1 comment
Assignees
@alban

Comments

@jonboulle
Copy link

Where possible, all app parameters should be copied at runtime into the runConfig.
@alban alban self-assigned this Feb 9, 2015
@alban
Copy link

alban commented Feb 10, 2015

When the option comes from the command line, it should just work because the ACI support does not change that. Examples:

  • Entrypoint/Cmd/Args: docker run --format aci --entrypoint /etcd coreos.com/etcd --election-timeout 900
  • User (--user)
  • Environment variables (--env)

When the option comes from the aci, it should be merged correctly:

  • Entrypoint / Cmd / Args
  • User (uid or username)
  • User (absolute path to a file)
  • Group
  • Environment variables
  • Isolators
  • Ports
  • Working directory
  • Mount points

Some app parameters will probably not be implemented in the ACI support:

  • Event handlers (pre-start, post-stop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alban alban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alban @jonboulle