Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

update travis and version for 3.0 release #50

Merged
merged 2 commits into from Sep 14, 2016

Conversation

loganwright
Copy link
Collaborator

Hey Dan,

Thanks for taking over for Honza 馃憤 , looking forward to parsing some more JSON.

This PR is because 3.0 is officially out on Linux, and we're looking to stabilize our dependencies w/ this 1.0 as soon as we can.

Thanks,

Logan

@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Current coverage is 86.89% (diff: 100%)

No coverage report found for master at 4bb31b2.

Powered by Codecov. Last update 4bb31b2...244fd33

@endocrimes
Copy link
Owner

Hey Logan,
Thanks for the PR!

Unfortunately I'd really rather not have us evaling curl output in tests where possible as this breaks usage of git bisect and to have repeatable builds throughout the history.

You are however welcome to submit a PR with the build scripts, but please break them out into the dependency and test steps, as this has much better support on CI.

@loganwright
Copy link
Collaborator Author

@dantoml Scripts are now committed in a .travis folder so they'll be tracked in history 馃憤

@endocrimes
Copy link
Owner

Great, thanks!

@endocrimes endocrimes merged commit 1c381d7 into endocrimes:master Sep 14, 2016
@loganwright
Copy link
Collaborator Author

Thanks for getting this in @dantoml! Sorry to keep pushing, but one more thing. Could we also get a 1.0.0 tag? That is the last thing blocking us from moving forward with out release 馃憤

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants