fix(compartment-mapper): there's more benefit to keeping __esModule flag than not #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lag than not (compiled TS depends on it across packages)
kriskowal
approved these changes
Apr 7, 2022
|
Can you frame this requirement as a test? |
I did, but in e2e tests. Will do. |
…ypescript esModuleInterop compatibility
naugtur
added a commit
that referenced
this pull request
May 16, 2022
…lag than not (#1145) * fix(compartment-mapper): there's more benefit to keeping __esModule flag than not (compiled TS depends on it across packages) * test(compartment-mapper): cover the presence of __esModule flag for typescript esModuleInterop compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiled TS depends on it across packages.
https://www.typescriptlang.org/tsconfig#esModuleInterop