Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hereditary-shims tests hit infinite loop #197

Closed
warner opened this issue Jun 7, 2018 · 1 comment
Closed

hereditary-shims tests hit infinite loop #197

warner opened this issue Jun 7, 2018 · 1 comment

Comments

@warner
Copy link
Contributor

warner commented Jun 7, 2018

Our best progress so far is on the hereditary-shims branch. To run the test, do this:

  • git clone this repo, git checkout hereditary-shims, then run git submodule init --update to populate the proposal-realms/ direcfory
  • npm install to get the dependencies
  • patch proposal-realms to get a version that doesn't freeze globals: cd proposal-realms; git remote add agoric https://github.com/agoric/proposal-realms; git remote update; git diff master...agoric/unfreeze-globals |patch -p1
  • run the only test that still halfway-works: ./node_modules/.bin/tape -r esm test/test_hereditary_realm.js

This currently gets stuck with an infinite loop as it attempts to create a second-level realm from inside a new first-level realm (the test named "nested realm, no shim"). The code all goes through src/hereditary.js, which is surely incomplete.

@warner
Copy link
Contributor Author

warner commented Jul 19, 2018

We switched approaches, so this is no longer relevant.

@warner warner closed this as completed Jul 19, 2018
@jfparadis jfparadis transferred this issue from Agoric/SES Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant