fix(compartment-mapper): Work around dynamic import censoring #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Nov 5, 2020
| @@ -28,7 +28,17 @@ | |||
| * comment: string, // presumed UTF-8 | |||
| * }} CentralDirectoryLocator | |||
| * | |||
| * @typedef {import('./buffer-reader.js').BufferReader} BufferReader | |||
There was a problem hiding this comment.
Oh damn. I didn't see this one coming. Unpleasant but I have no suggested improvement.
There was a problem hiding this comment.
It’s technically an improvement for the type here to express what’s needed since it doesn’t depend on the concrete type. But, in the future, we will need other work-arounds.
kriskowal
commented
Nov 5, 2020
Comment on lines
+57
to
+58
| // Wrap import calls to bypass SES censoring for dynamic import. | ||
| // eslint-disable-next-line prettier/prettier |
There was a problem hiding this comment.
Added this boilerplate to stop lint --fix from erasing the “unnecessary” parentheses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change puts a ring of parentheses on calls to
import, and inlines type definitions for buffered reader and writer to avoid usingimportat all in TypeScript JSDoc type annotations.