Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we export a default makeHardener? #81

Closed
warner opened this issue Feb 19, 2019 · 1 comment
Closed

do we export a default makeHardener? #81

warner opened this issue Feb 19, 2019 · 1 comment

Comments

@warner
Copy link
Contributor

warner commented Feb 19, 2019

I just noticed that some downstream code (SES) fails when I do import makeHardener from '@agoric/make-hardener' (after doing an npm install ../MakeHardener). Are we exporting a composite object with a makeHardener property, or a single default function? I think we should be doing the latter.

@katelynsills can you check me on this?
@katelynsills
Copy link
Contributor

Yup! On it.

katelynsills referenced this issue in Agoric/make-hardener Feb 19, 2019
@katelynsills
Merge pull request #9 from Agoric/change-exports
4cbbe95 
switch to exporting a single default property. Fixes #8
@jfparadis jfparadis transferred this issue from Agoric/make-hardener Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warner @katelynsills