Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua submodule ref missing #14

Closed
BenGardiner opened this issue Jan 25, 2017 · 3 comments
Closed

lua submodule ref missing #14

BenGardiner opened this issue Jan 25, 2017 · 3 comments

Comments

@BenGardiner
Copy link

Following the git clone, cd, git submodule init, git submodule update process on 20160124; the submodule update command failed with

$ git submodule update
fatal: reference is not a tree: 7d19fe6f4d59543ce5a61b640350805064ac5652
Unable to checkout '7d19fe6f4d59543ce5a61b640350805064ac5652' in submodule path 'src/wsh/lua'

Was 7d19fe6f4d59543ce5a61b640350805064ac5652 in a branch other than master in https://github.com/lua/lua.git ? Because checking out master instead results in a make error:

[...]
make[3]: Leaving directory `/home/bengardiner/src/wcc/src/wsh/openlibm'
cd lua && make linux CFLAGS="-fpie -fPIC"
make[3]: Entering directory `/home/bengardiner/src/wcc/src/wsh/lua'
make[3]: *** No rule to make target `linux'.  Stop.
[...]
@ForceFaction
Copy link

ForceFaction commented Jan 29, 2017

I have the same problem right now ...

I noticed that the makefile in luas master branch has indeed no linux target, but the release http://www.lua.org/work/lua-5.3.4-rc3.tar.gz has it.

I simply removed the lua submodule and unpacked the release tarball in the same place, that gives me no compilation errors, but wsh crashes with a Segmentation Violation 😂 ...

EDIT: I just noticed that the version used should be 5.3.2 (the version control headers have the exact same time)

EDIT: Okay the segfault happens, because there are too many hardcoded paths in the code, on a VM with ubuntu i do not have any segfaults ... but i still need to manually download and extract the http://www.lua.org/work/lua-5.3.2.tar.gz release in src/wsh/lua ... and it works

@xorond
Copy link
Contributor

xorond commented Apr 10, 2017

Would like to mention that this issue also affects the wcc-git package in ArchStrike.

@endrazine
Copy link
Owner

Hi team, this is fixed with commit 043ee4e

Thanks for your help with this one !

j-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants