Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portrait / upright videos #6

Open
bdoubleu86 opened this issue Dec 21, 2019 · 8 comments
Open

Portrait / upright videos #6

bdoubleu86 opened this issue Dec 21, 2019 · 8 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bdoubleu86
Copy link
Contributor

I am getting the wrong width and height for a video which is in portrait.
I solved it by considering "rotation" and then switch width and height.

Moreover, I am not getting correct thumbnails from portrait videos.
For this issue I did not find a solution with your plugin. Is this issue know? Do you know a solution?

@ened
Copy link
Owner

ened commented Dec 21, 2019

Hi @bdoubleu86 thx for the report. Can you share a sample video that I could include in a public test case?

@bdoubleu86
Copy link
Contributor Author

bdoubleu86 commented Dec 21, 2019

You can try: http://files.danceapp.de/IMG_6078.MOV

It is a very short video tho.

@bdoubleu86
Copy link
Contributor Author

For the width/height I provided a PR that fixes the issue.
For the distorted thumbnail I realized it is only a problem with Android. iOS works fine.

@ened
Copy link
Owner

ened commented Dec 22, 2019

@bdoubleu86 your PR has been merged and is published as part of version 0.6.0 of this plugin. This ticket will remain open until we have fully working E2E testing ready (you can track the progress in the e2e branch). Thank you for your support!

@bdoubleu86
Copy link
Contributor Author

@ened Did you get the chance to solve the issue with the distorted video thumbnail? Looks like it is only an issue on Android. iOS works fine.

@ened
Copy link
Owner

ened commented Jan 2, 2020

@bdoubleu86 not yet. Appreciate a PR if you have time. If not, I will work on it next week.

@jpiabrantes
Copy link

I am also getting the distorted thumbnail problem. Any plans to fix this?

@bdoubleu86
Copy link
Contributor Author

I am using video_thumbnail plugin until this issue is fixed in media_info

@ened ened added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants