Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ability to search for amounts #135

Open
Zaptro opened this issue Apr 30, 2022 · 4 comments
Open

Feature request: Add ability to search for amounts #135

Zaptro opened this issue Apr 30, 2022 · 4 comments
Labels
enhancement New feature or request testing

Comments

@Zaptro
Copy link

Zaptro commented Apr 30, 2022

Hello,

the main nextcloud search field on the upper right does not seem to be connected to be able to filter by amount. However, it would be really useful for me to see, wether I already added an entry of for example a bill to the database by just typing in the amount to search for. This would make finding a certain entry very fast.

Yours sincerely
Zaptro

julien-nc pushed a commit that referenced this issue May 8, 2022
…re or less 1.0

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc added enhancement New feature or request testing labels May 8, 2022
@julien-nc
Copy link
Owner

julien-nc commented May 8, 2022

Hi, thanks for the feature request. I agree it can be convenient to search and filter by amount.

This has been added and is available in the latest nightly (v1.4.7-2-nightly).

It impacts the unified search results and the bill list filtering. Both will show bills having their amount matching QUERY - 1 <= BILL_AMOUNT <= QUERY + 1 to avoid having to type the exact amount. What do you think about that?

It would be nice if you could try it before the next release. Here is how to install the nightly.

@Zaptro
Copy link
Author

Zaptro commented May 22, 2022

Hello, thank you for implementing this feature that fast in a nightly release! It works!

But I think the bill list filtering is a bit bugged still: The unified search shows for me e.g. 5 entries that are in the range of "23" +/- 1 but the bill list only shows one entry. I think I found out, that the bill list only shows the entries for the current year, whereas the unified search shows every entry of the current and past years?

julien-nc pushed a commit that referenced this issue May 22, 2022
… like any other filter, let the server do the search => infinite loading now works with text search

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Thanks for the feedback.

The problem is that the bill list filtering happens on the frontend which does not load all bills (infinite loading mechanism). It loads 50 bills (without filtering) and then when you filter, you only see the matching bills in those 50.

This is now fixed. Filtering is done on the server side when getting the bills. Each time a filter value changes, the bill list is reset and the 50 first matching bills are obtained. This allows the infinite loading mechanism to work with filters as well. It's much clearer and cleaner now.

v1.4.7-7-nightly is out. Could you try it out?

I'm also interested in your feedback regarding the latest design changes.

  • All icons are now material design ones.
  • Weight, Repeat, Duplicate bill, Category, QRCode, icons and many others look different.
  • Most buttons are now bigger (using Nextcloud-Vue ones).

@x29a
Copy link

x29a commented Jun 5, 2023

Following up on this, is it possible to filter/query by amount range?

Use case: i have >1000 bills and would like to see if i put in the vacation one already and i know it was more than 500 eur, but could be 600 or so (so not starting with "5").

I dont know the exact title, payment type, category or amount.

I tried ">500" in the unified search, that didnt work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

3 participants