Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add member through public link #68

Closed
la-balisa opened this issue Aug 2, 2021 · 14 comments
Closed

Cannot add member through public link #68

la-balisa opened this issue Aug 2, 2021 · 14 comments
Labels
bug Something isn't working testing

Comments

@la-balisa
Copy link
Contributor

Hi. I currently own a shared Cospend project, and we realized that guests cannot add a new member.

Config :
Nextcloud 21 (Dockerized)
MariaDB NC database
Cospend 1.3.7
Tested on Firefox 78.9 and Chromium 89

Steps :

  • Create a new project
  • Create a public link, grant it Maintainer or Admin permission
  • Open the link in a new (private) browser window
  • Go to Settings (or tree-dots-menu -> Add member)
  • Enter a new username -> there is no way to validate it (no button, and Enter key not doing anything) ; it seems to just do a search through the existing members, but with always no results

I expect this menu to have the same behavior as when logged as project-owner : it displays a "Create simple member" button when typing a username, and Enter key does the same.

@julien-nc julien-nc added bug Something isn't working todo labels Aug 2, 2021
@julien-nc
Copy link
Owner

Thanks for the bug report. I'll fix this in a few weeks.

julien-nc pushed a commit that referenced this issue Aug 2, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

The bug was quite simple to fix. Finally it did it. It's available in latest nightly build (only compatible with Nextcloud 22, sorry).

If at some point you upgrade to NC 22 and want to try the nightly, you can get it with an occ command:

occ app:update --allow-unstable cospend

When you want to get back to normal releases, just disable and remove the app from app settings and reinstall it. You won't loose any data.

@la-balisa
Copy link
Contributor Author

Nice, thank you :-)

I will try as soon as i update to NC 22 ! (but i still have to figure how to check which apps will be disabled before updating, as it seems many useful apps are broken right now...)

@julien-nc
Copy link
Owner

You can check your apps compatibility on the appstore website, you can see there, for example, that Cospend v1.3.7 is compatible with NC 20 and 21 and v1.3.10 with NC 22.

It would be great if you would be able to try the nightly before the next release 😁.

@la-balisa
Copy link
Contributor Author

I just setup a test NC22 instance, and with nightly (1.3.11), but sadly guest link functionality seems to be totally broken :(
Apart from the header (NC logo + "Cospend public access ; Project test" text), the page is totally blank when accessing public link from a private browsing session (Firefox or Chromium).

Reverting to Cospend 1.3.10 (by uninstalling and reinstalling it) fix it (but does not fix the original bug).

@julien-nc
Copy link
Owner

I don't know how this happens to you. Guest access works fine with v1.3.11-6-nightly on multiple test instances on my side.

Any error in the browser log or server log?

@julien-nc
Copy link
Owner

Or it can be a browser cache issue? You can try to refresh the guest access page with CTRL+F5

@la-balisa
Copy link
Contributor Author

la-balisa commented Aug 3, 2021

Every try is done through Ctrl+F5, and i tried from 2 differents browsers.
I have no idea neither :/ I'm don't know how to make sure i'm on 1.3.11-6, but it is installed through the command-line you provided to allow unstable upgrades.
I don't see anything suspicious in nextcloud.log (actually nothing after yesterday) or the docker logs for my container (only GET request from apache log).

Nextcloud is dockerized, and my web setup is behind a reverse proxy, and a NAT, maybe that could be related ?
I saved both (1.3.10 and 1.3.11) html source code (client-side), could that be useful ?

I can also provide an access to my test server if you want (as i am not really able to use browser console, and such tools)

@julien-nc
Copy link
Owner

I can also provide an access to my test server if you want (as i am not really able to use browser console, and such tools)

Yes why not. You can send me the details by e-mail if you want (check the commits of this project to get my address).

I'm don't know how to make sure i'm on 1.3.11-6

The occ command should have told you.

Nextcloud is dockerized, and my web setup is behind a reverse proxy, and a NAT, maybe that could be related ?

I don't think so.

I saved both (1.3.10 and 1.3.11) html source code (client-side), could that be useful ?

Nope 😁

@julien-nc
Copy link
Owner

Btw, thank you for your patience 😁. We're going to figure this out.

@la-balisa
Copy link
Contributor Author

Thanks goes to you for your work :)
I did not have dash-version numbers in the occ command, only 1.3.10 and 1.3.11. My command looked like : docker exec -u www-data cloud_test sh -c "php /var/www/html/occ app:install cospend"

Mail is sent if you want to test it !

julien-nc pushed a commit that referenced this issue Aug 6, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Nice. I could spot the bug and fix it. It was about the accessibility app not being enabled in public pages.
The fix is included in the latest nightly (v1.3.12-3-nightly). Could you try it?

By the way, if you really want to make sure you're using the right nightly, you can download it manually from the appstore and place it in your apps directory.

@julien-nc julien-nc added testing and removed todo labels Aug 6, 2021
@la-balisa
Copy link
Contributor Author

It works fine with last version, either from app:update or manually unpacking the app !
Page is no longer blank, and member creation is working from guest access. Kudos :)
I think we can close the issue ?

@julien-nc
Copy link
Owner

Yay thanks a lot for the feedback. v1.3.12 is coming soon (thanks to you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

No branches or pull requests

2 participants