Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate bill as new #70

Closed
TtuxX opened this issue Aug 4, 2021 · 9 comments
Closed

Duplicate bill as new #70

TtuxX opened this issue Aug 4, 2021 · 9 comments
Labels

Comments

@TtuxX
Copy link

TtuxX commented Aug 4, 2021

Hello @eneiluj!

First of all, let me thank you for your amazing app and all the wonderful features it offers.
It is regularly extremely useful to me. It is for me the most complete and well-rounded application in the nextcloud ecosystem. Thank you so much for such a powerful application you have created and for the time you put into making it better and better!

I'm planning a trip with a friend and we keep our accounts balanced by paying each other back.
However, sometimes I just want to "duplicate as new" an existing bill to change just a thing or two, but there is no option to do so.

Do you think it could be possible to have such an option to quickly duplicate as new an existing bill?

julien-nc pushed a commit that referenced this issue Aug 5, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc added enhancement New feature or request testing labels Aug 5, 2021
@julien-nc
Copy link
Owner

Hey!

Thanks for your compliments. Always a pleasure to know the app is appreciated!

And thanks for the good idea! Simple and useful. It was quite easy to implement. The way it's currently done can mess with disabled members. If a member's balance was brought back to zero and this member was disabled, it becomes hidden. Then if you duplicate a bill in which this member is involved, it will change the balance and show the member again. I'll fix that by automatically removing disabled owers in duplicated bill and keep you updated here.

So the feature is available in the latest nightly (v1.3.12-1-nightly). You can get it with an occ command:

occ app:update --allow-unstable cospend

When you want to get back to normal releases, just disable and remove the app from app settings and reinstall it. You won't loose any data.

julien-nc pushed a commit that referenced this issue Aug 5, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc pushed a commit that referenced this issue Aug 5, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Ok done. In v1.3.12-2-nightly, disabled owers are not included in duplicated bills and duplication is inhibited if the payer is disabled.

@TtuxX
Copy link
Author

TtuxX commented Aug 6, 2021

Dear @eneiluj, thank you so much for your awesome work and for your impressive reactivity, I just tried your new option and it is perfect and very straightforward! :)
Do you know if we will also have the chance to get this option in the MoneyBuster app ?

Also - not sure why - but very recently Cospend app stopped displaying content, throwing an "Uncaught TypeError: OCA.Accessibility is undefined" as I had the Accessibility app disabled.
I enabled it and Cospend app works great again in the browser.
Is it expected ? If not, would you prefer me to open another issue ?

julien-nc pushed a commit that referenced this issue Aug 6, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Yay thanks for the feedback. I don't know about MoneyBuster, maybe it will but not soon.

About the Accessibility app issue. It's now solved, thanks for pointing on it. Could you try v1.3.12-3-nightly?

@TtuxX
Copy link
Author

TtuxX commented Aug 6, 2021

Everything now works perfectly, thank you so much Julien! :)

@TtuxX TtuxX closed this as completed Aug 6, 2021
@julien-nc
Copy link
Owner

Well thank you again for your enthusiasm and great feedback. See you around!

@TtuxX
Copy link
Author

TtuxX commented Jan 1, 2023

@julien-nc Hi Julien and Happy New Year !! :)

Thank you once again for this great and very useful functionality.
Would it be possible to also add a "Duplicate this bill" shortcut entry directly in the three-dots menu that we see on the picture hereunder?

image

Thank you very much !

julien-nc added a commit that referenced this issue Jan 1, 2023
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
Copy link
Owner

Hey @TtuxX ! Happy new year to you too.

Nice idea. Done and available in v1.5.5-2-nightly. It would be nice if you could try it. You can also wait for v1.5.5.

@TtuxX
Copy link
Author

TtuxX commented Jan 2, 2023

Thank you very much Julien, it works great (tried on v1.5.5) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants