Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive queries to google servers? #18

Closed
kevinlekiller opened this issue May 3, 2020 · 3 comments
Closed

Excessive queries to google servers? #18

kevinlekiller opened this issue May 3, 2020 · 3 comments

Comments

@kevinlekiller
Copy link

kevinlekiller commented May 3, 2020

Hello, I installed this addon yesterday, I was just looking at pihole and noticed a massive amount of queries from the the pi with libreelec on it (~10 DNS queries per second) 270k+ queries in ~12 hours, I uninstalled the addon and the queries stopped.

(2:00 is a little while after I installed the addon, the hours of 6:00 to 9:00 kodi was playing videos)

Screenshot_20200503_171459

@kevinlekiller
Copy link
Author

I haven't done any debugging, but looking at the source ;

https://github.com/enen92/screensaver.kaster/blob/master/resources/lib/screensaver.py#L76

There should be a sleep before this continue.

If the server continuously returns a response other than 200 (like if the server return 429 Too Many Requests for example) this will cause high CPU usage and tons of requests.

@kevinlekiller
Copy link
Author

Not related to the issue, but adding a else with a break 2 or return here wouldn't let the for loop go all the way through to save a bit of cpu time:

https://github.com/enen92/screensaver.kaster/blob/master/resources/lib/screensaver.py#L113

@enen92
Copy link
Owner

enen92 commented Jun 22, 2020

Thanks for reporting. Should be fixed in 2d4d63c

@enen92 enen92 closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants