Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions #21

Closed
kavvkon opened this issue Oct 15, 2018 · 2 comments
Closed

Naming conventions #21

kavvkon opened this issue Oct 15, 2018 · 2 comments
Milestone
v 2.3

Comments

@kavvkon
Copy link
Member

kavvkon commented Oct 15, 2018 •
edited
Loading

Currently:
Github repo: Dispa-SET
package folder: DispaSET
package name in setup.py: dispaset
command line interface: dispaset
documentation website: dispaset.eu

Proposal:

  • rename package folder (and consequently package name) from DispaSET to dispaset. This simplifies/harmonizes some things, and is inline with python naming conventions. This means the import will be changed to import dispaset as ds. See also Automatic unit tests #3.
  • Keep official name in manuals and documents as Dispa-SET.
@kavvkon kavvkon added this to the v 2.3 milestone Oct 15, 2018
@squoilin
Copy link
Member

I am fine with this. Is it ok if we first merge the EU branch into master and then apply the pull request?

@kavvkon
Copy link
Member Author

kavvkon commented Nov 19, 2018

OK ! When everything else is merged to master, I will merge #3

@kavvkon kavvkon closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v 2.3
Development

No branches or pull requests
2 participants
@squoilin @kavvkon