Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue claim): allow boolean as valid field #639

Merged
merged 1 commit into from Aug 15, 2022
Merged

Conversation

whitneypurdum
Copy link
Member

@whitneypurdum whitneypurdum commented Aug 12, 2022

Description

For bug: https://energyweb.atlassian.net/browse/SWTCH-1409
issuerFields can be a boolean value, which is not a valid type in this field check.
const issuerFields = [{key: 'Checkboolean ', value: true}]

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@whitneypurdum whitneypurdum changed the title fix(infura): replace config with ipfs daemon for initUser methods fix(issue claim): allow boolean as valid field Aug 12, 2022
@whitneypurdum whitneypurdum marked this pull request as draft August 12, 2022 20:53
@whitneypurdum whitneypurdum marked this pull request as ready for review August 15, 2022 10:57
@whitneypurdum whitneypurdum merged commit 77eb426 into develop Aug 15, 2022
ewf-devops pushed a commit that referenced this pull request Aug 15, 2022
### [6.0.1-alpha.1](v6.0.0...v6.0.1-alpha.1) (2022-08-15)

### Bug Fixes

* **issue claim:** allow boolean as valid field ([#639](#639)) ([77eb426](77eb426))
@ewf-devops
Copy link

🎉 This PR is included in version 6.0.1-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

ewf-devops pushed a commit that referenced this pull request Aug 31, 2022
### [6.0.1](v6.0.0...v6.0.1) (2022-08-31)

### Bug Fixes

* **exp:** document expirationTimestamp ([#631](#631)) ([9595c34](9595c34))
* **issue claim:** allow boolean as valid field ([#639](#639)) ([77eb426](77eb426))
* use resolveCredentialAndVerify to verify enrolment prerequisites ([#630](#630)) ([9208ad3](9208ad3))
@ewf-devops
Copy link

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrhender jrhender deleted the issuerFields branch December 6, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants