Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoldItem causing entire component to re-render #117

Open
Kaique292 opened this issue May 19, 2024 · 7 comments
Open

HoldItem causing entire component to re-render #117

Kaique292 opened this issue May 19, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Kaique292
Copy link

Well, I'm using HoldItem in a list, as a child element I have a checkbox, whenever this checkbox is updated, HoldItem is making my entire component re-render. Causing the other element, which is an image, to be reloaded unnecessarily. I've done everything with this component, I've contacted the developer but no response. I'll wait for a solution here, if not, I think I'll make this component from 0 myself...

Expo SDK: 51.0.8

snapcode

@Kaique292 Kaique292 added the bug Something isn't working label May 19, 2024
@Kaique292
Copy link
Author

If I remove the HoldItem, and use a View directly, the entire component does not re-render, only the checkbox

@fukemy
Copy link

fukemy commented May 20, 2024

could you remove transition props? When hold active, the hole item got re-render, the problem is about your Image, it's load again.

@Kaique292
Copy link
Author

could you remove transition props? When hold active, the hole item got re-render, the problem is about your Image, it's load again.

Like i say, the problem is not the image, because if i remove HoldItem and use View instead, works fine

@Kaique292
Copy link
Author

I don't activated the holdItem, I just clicked on the checkbox. I didn't want to use the development build, but I'm strongly considering it, and then I'm going to migrate to Zeego library, it's much more up-to-date and stable with Expo.

@fukemy
Copy link

fukemy commented May 20, 2024

I don't activated the holdItem, I just clicked on the checkbox. I didn't want to use the development build, but I'm strongly considering it, and then I'm going to migrate to Zeego library, it's much more up-to-date and stable with Expo.

Zeego UI look bad to Android because it use 'PopupWindow' to display menu, if you can make sample git I can help you

@jingledongding
Copy link

me too

@tconroy
Copy link

tconroy commented Jun 22, 2024

I am having a very similar issue, specifically when closing the hold menu, my component appears to flicker/re-mount. This only happens after the first open/close (ie it starts to flicker on the 2nd open/close).

Did you ever find a way to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants