Skip to content
This repository has been archived by the owner on Feb 27, 2020. It is now read-only.

Wrong activity type should be a User Exception #194

Closed
phact opened this issue Jan 29, 2020 · 2 comments
Closed

Wrong activity type should be a User Exception #194

phact opened this issue Jan 29, 2020 · 2 comments

Comments

@phact
Copy link
Collaborator

phact commented Jan 29, 2020

https://github.com/engineblock/engineblock/blob/master/eb-api/src/main/java/io/engineblock/util/SimpleServiceLoader.java#L46

@phact
Copy link
Collaborator Author

phact commented Jan 29, 2020

Which is not that simple because eb-util doesn't import eb-core. This promises to become a major problem with dependencies.

Why don't we use an Exception from java.lang? Maybe something like UnsupportedOperationException?

@jshook
Copy link
Member

jshook commented Feb 24, 2020

I've logged this in the new consolidated project as nosqlbench/nosqlbench#3, and added details on implementation that should clarify how to deal with the dependency issues.

@jshook jshook closed this as completed Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants