This repository has been archived by the owner on Jun 21, 2020. It is now read-only.
BLD: adjusting to core & ppal msgs #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elichai please take a look at this |
elichai
suggested changes
Apr 3, 2019
| "minItems": 1 | ||
| } | ||
| } | ||
| "preCode": {"type": "string"} |
There was a problem hiding this comment.
I'm not sure how did that happen but I think the right thing to do is to change it in core to Vec<u8>
lacabra
added a commit
that referenced
this pull request
Apr 3, 2019
lacabra
force-pushed
the
smallAdjustments
branch
from
6425a81
to
19f206a
Compare
lacabra
added a commit
that referenced
this pull request
Apr 3, 2019
lacabra
force-pushed
the
smallAdjustments
branch
from
19f206a
to
23b22a0
Compare
|
@Isan-Rivkin, @lenak25: As far as I'm concerned, this is ready to merge because all requested changes have been addressed where relevant. There is an item that @elichai wants to change in core, but in the interest of time, I would merge this as is; and submit a different PR for when |
elichai
reviewed
Apr 8, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetPTTRequestthat was emptypreCodeinDeploySecretContractthat comes in as a hex string from core, instead of the byte array.GetStateKeysAction.jsaccounts for being called without specifyingparamswhich would otherwise throw an error around L21, and unpacks the error object and displays it properly in L45