New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto crate to the toolkit #4
Conversation
Thanks @PumpkinSeed! @reuvenpo can you take a look and make sure everything is rusty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not export the crypto
subcrate from the main secret_toolkit
namespace. I'll do it for you real quick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome PR, thanks @PumpkinSeed :D
Based on the I609 I moved the original content to the crypto crate and make them public based on the pattern of the other crates.
Also changes on my side:
Leftover:
I didn't add ed25519 signing however the original ticket contains it. This requires a decision on your part, since I found a crate for that purpose, I would say do it in a different PR.
Also to make it consistent, currently the sign.rs only support secp256k1, I don't know whether we can use the same parameter-set for ed25529, but if yes we can create an enum for decide between algorithms to sign the data.