Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConnectionNack message to protocol #78

Closed
Kingdutch opened this issue Nov 24, 2020 · 4 comments
Closed

Add ConnectionNack message to protocol #78

Kingdutch opened this issue Nov 24, 2020 · 4 comments
Labels
question Further information about the library is requested

Comments

@Kingdutch
Copy link

Story

As a developer I want a message type so that I can inform clients of the reason for the denial of their connection request.

As a client I want to know why my ConnectionInit request was not accepted so that I can fix the issue (e.g. prompt user for auth data) rather than have the connection suddenly close.

Acceptance criteria

  • A developer is able to inform the client why a connection request was denied (for example invalid authentication data)
@Kingdutch
Copy link
Author

I realised this can be treated as an "Invalid Message"

@enisdenjo
Copy link
Owner

I think you might find #75 interesting! 😄

@Kingdutch
Copy link
Author

I saw that and it is interesting, but that doesn't stretch to PHP unfortunately ;-)

I'm working on a PHP implementation for the protocol based on Ratchet so sending custom stuff is already easy. I just want to make sure it sticks to the defined protocol so that GraphQL clients using this transport layer can talk to it :)

@enisdenjo
Copy link
Owner

Absolutely lovely to hear! 😄

In general, I try to be as close as possible to the pure necessities of GraphQL with the Protocol. You should be able to handle auth, and other GraphQL unrelated topics, how ever you see fit.

@enisdenjo enisdenjo added the question Further information about the library is requested label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information about the library is requested
Projects
None yet
Development

No branches or pull requests

2 participants