Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs are not dismissing on navigated pages causing an eventual crash #665

Open
laszlodaniel opened this issue May 7, 2024 · 1 comment
Labels
bug-verified A bug that can be reproduced core-dialogs
Milestone

Comments

@laszlodaniel
Copy link

laszlodaniel commented May 7, 2024

Description

None of the dialog services work on navigated pages. Dialogs pop up and seemingly return information but they won't disappear. Then an unhandled exception is thrown on second button tap.

Dialogs are ok on the main page.

CommunityToolkitDialog and MopupsDialog is also affected.

UraniumUI_Popup_issue_01

Steps to reproduce

Download and try this sample project: UraniumUIPopupTest.zip.

Version with bug

		<PackageReference Include="CommunityToolkit.Maui" Version="9.0.0" />
		<PackageReference Include="CommunityToolkit.Mvvm" Version="8.2.2" />
		<PackageReference Include="Microsoft.Maui.Controls" Version="8.0.21" />
		<PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="8.0.21" />
		<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="8.0.0" />
		<PackageReference Include="UraniumUI" Version="2.8.1" />
		<PackageReference Include="UraniumUI.Dialogs.CommunityToolkit" Version="2.8.1" />
		<PackageReference Include="UraniumUI.Dialogs.Mopups" Version="2.8.1" />
		<PackageReference Include="UraniumUI.Material" Version="2.8.1" />
@enisn enisn added core-dialogs bug-verified A bug that can be reproduced labels May 8, 2024
@enisn enisn added this to the v2.9 milestone May 8, 2024
@enisn
Copy link
Owner

enisn commented May 8, 2024

Mopups & Community Toolkit dialogs are working but DefaultDialogService doesn't work. It seems it's related to AppShell navigation logic.

If you remove the following line from MauiProgram.cs, CommunityToolkit or Mopups implementation will work.

builder.Services.AddSingleton<IDialogService, DefaultDialogService>();

image
mopups-work

I'll take a look at Default implementation, it may be related to a MAUI bug since code seems correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-verified A bug that can be reproduced core-dialogs
Projects
None yet
Development

No branches or pull requests

2 participants