Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to decode pfx file with the x509-certificate-exporter? #42

Closed
strossan opened this issue Aug 12, 2021 · 3 comments
Closed
Assignees
Labels
question Further information is requested wontfix This will not be worked on x509-certificate-exporter

Comments

@strossan
Copy link

No description provided.

@npdgm npdgm self-assigned this Aug 13, 2021
@npdgm npdgm added question Further information is requested x509-certificate-exporter labels Aug 13, 2021
@npdgm
Copy link
Member

npdgm commented Aug 13, 2021

Hi @strossan,
It is not possible to read PKCS#12 bundles with this exporter for now, only PEM encoded X.509 certificates are supported.
I'm interested about new use cases and would like to evaluate if this could be implemented.
Would you mind telling more about the typical environment where you encounter these files? What platform and software stack if they are commonly known tools. This is only out of curiosity because as maintainers of this project we don't see many PKCS files these days, especially not on systems where the x509-certificate-exporter is deployed.
Thank you

@strossan
Copy link
Author

We started to implement Kubernetes environments recently. We, for the moment, use Azure Kubernetes Services (AKS). Part of our process, we create keyvaults in Azure, so we can encrypt values for various SaaS we use and pass the information to our micro services. It happens to be done with PKCS#12.
I put the request because it could be something you support or may want to support down the road. Thanks for considering it.

@npdgm npdgm added the wontfix This will not be worked on label Aug 8, 2022
@npdgm npdgm transferred this issue from enix/helm-charts Aug 8, 2022
@npdgm
Copy link
Member

npdgm commented Aug 8, 2022

Hi,
Implementing support for PKCS#12 has been evaluated a couple times. When working on version 3 we investigated what libraries could be used, as the standard golang library barely provide interfaces for this format.
We ultimately decided not to support PKCS#12.

Friction points are:

  • unsatisfactory standard library and wish not to depend on large crypto packages
  • conflicts on how to handle both formats: probing files doesn't feel like a clean method, and the remaining choice is to significantly refactor code and command-line arguments
  • PKCS#12 bundles are more complex and raise problems we didn't have to handle with PEM blobs. We don't want to purposely ignore corner cases.
  • likely risk of having to alter metrics specifications

So eventually we will only support PEM for the time being. Design choices have been made on these premises and it keeps things simple and easier to maintain.

@npdgm npdgm closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on x509-certificate-exporter
Projects
None yet
Development

No branches or pull requests

2 participants