Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Modded Armor #6

Closed
ardissaps opened this issue May 28, 2022 · 5 comments
Closed

Does not work on Modded Armor #6

ardissaps opened this issue May 28, 2022 · 5 comments

Comments

@ardissaps
Copy link

ardissaps commented May 28, 2022

Transparency does not work on modded armor but hide enchantment works fine.

Edit :

  • Hide enchantmen also does not work on modded armors.
  • Does not hide elytra on trinket mod slot.
@enjarai
Copy link
Owner

enjarai commented May 28, 2022

What modded armor specifically does it not work with?

@ardissaps
Copy link
Author

ardissaps commented May 28, 2022

What modded armor specifically does it not work with?

Immersive Armor :
https://www.curseforge.com/minecraft/mc-mods/immersive-armors

Elytra Trinket (unable to hide) :
https://www.curseforge.com/minecraft/mc-mods/elytra-trinket-fabric

@enjarai
Copy link
Owner

enjarai commented May 28, 2022

At a glance I can tell that Immersive Armor uses a highly custom armor renderer for it's 3d shapes. So it's not surprising to me that it doesn't work out of the box.

Looking more closely into its source code, I think it's not worth my time to add support for it. I am however open to merging a pull request for this.

Elytra Trinket has a similar problem, in that it basically copies the vanilla elytra rendering code, bypassing my modifications. This does seem like it'd be easy to support with an optional mixin though, so I'll see what I can do about it.

@enjarai
Copy link
Owner

enjarai commented May 28, 2022

I got Elytra Trinket working, compatibility will be included in the next update.

@enjarai enjarai closed this as completed May 28, 2022
@ardissaps
Copy link
Author

I got Elytra Trinket working, compatibility will be included in the next update.

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants