Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support choice styling with markdown / span #161

Open
tinok opened this issue Mar 9, 2020 · 2 comments
Open

Support choice styling with markdown / span #161

tinok opened this issue Mar 9, 2020 · 2 comments

Comments

@tinok
Copy link
Contributor

tinok commented Mar 9, 2020

At the moment, Enketo Express does not support styling choice labels the way that question labels already do. This is supported by ODK Collect.

See the Form styling documentation for Collect and the XLSForm documentation.

@MartijnR
Copy link
Member

MartijnR commented Mar 9, 2020

Thanks. It's good to have an issue for this to refer to.

I am not in favor of resolving this (though technically very easy) because:

  1. It means we'd have to move markdown parsing to the client. The costs in performance will be high. I don't think they outweigh the (I daresay minor) benefit of having this feature.

  2. In order to support it on mobile devices for select_multiple/select_one with minimal, we'd have to move away from native HTML <select> elements, which I think will be a deterioration in mobile usability of these question types. Excluding those would be tough to explain because the same form would be different on non-touchscreen and touchscreen devices.

@lognaturel
Copy link
Contributor

lognaturel commented Mar 21, 2023

The current approach to markdown is slow because of the replacement step at the end but that can be replaced.

Likely next step: move MD processing client-side, make it performant, stop using Transformer MD processing

After that: make sure https://docs.getodk.org/form-styling/#markdown has full specification of what we want to support and replace custom implementation with off the shelf one (likely https://remark.js.org/)

@lognaturel lognaturel transferred this issue from enketo/enketo-core Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants