Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new drawing on low-resolution screen is cut off in submission (pages mode, non-last page) #1291

Closed
MartijnR opened this issue Jan 2, 2024 · 2 comments · Fixed by #1292
Closed
Labels
bug Something isn't working

Comments

@MartijnR
Copy link
Member

MartijnR commented Jan 2, 2024

Describe the bug
When creating a drawing on small resolution mobile or desktop screen only the top left corner is submitted when the form is in Pages mode and the drawing is not on the last page.

To Reproduce
Steps to reproduce the behavior. If applicable please include the smallest possible XLSForm or XForm (as zip or link).

  1. Load this form in enketo-express
  2. Easiest is to set devtools to mobile mode (I used iPhone SE simulation) or to make the regular desktop screen quite small.
  3. Create a drawing
  4. Submit
  5. Inspect the submitted image and notice that it has been cut off

Expected behavior
For the complete image to be submitted.

Screenshots

Screenshot 2024-01-02 at 1 49 18 PM

Submitted:

drawing-13_49_10

Browser and OS (please complete the following information):

  • Tested in Chrome on Mac OS 13.6.1 and Chrome and Safari on the latest iOS

Additional context

Though it doesn't deal with loading an existing image, it sounds like the cause might be related to what is mentioned in #1290 (comment) and #1290 (comment)

@MartijnR MartijnR added the bug Something isn't working label Jan 2, 2024
@MartijnR MartijnR changed the title new drawing on low-resolution screen is cut off in submission new drawing on low-resolution screen is cut off in submission (pages mode, non-last page) Jan 2, 2024
@lognaturel
Copy link
Contributor

Agreed it's very likely related. Maybe the best short-term approach is to roll back the change that kept higher resolution images. We know that change was important to some users and rolling it back will be disruptive but now that we know there's data loss here it probably doesn't make sense to keep as it is.

@MartijnR
Copy link
Member Author

MartijnR commented Jan 3, 2024

Yes, that makes sense, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants