Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-buttons appearance seems to have no effect on vertical selects #164

Open
nonorval opened this issue Feb 24, 2020 · 2 comments
Open

No-buttons appearance seems to have no effect on vertical selects #164

nonorval opened this issue Feb 24, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Likely a good issue for a contributor

Comments

@nonorval
Copy link

Steps to recreate:
Render an XForm with a select field with appearance attribute set to "no-buttons" (without any columns specifier)

What I expect to see:
The radio buttons for the vertically oriented select are hidden.

What I see:
The radio buttons are still displayed.

I think the issue might relate to changes made a while ago for the columns styles and I have started working on a possible fix, but I wanted to check whether this is a known issue or what the intended behaviour might be.

@MartijnR
Copy link
Member

Thanks! This was not a known issue. A PR would be great!

@MartijnR MartijnR added bug Something isn't working good first issue Good for newcomers help wanted Likely a good issue for a contributor labels Feb 24, 2020
@nonorval
Copy link
Author

nonorval commented Mar 3, 2020

@MartijnR Sorry for the delayed response. I think I have a decent fix locally, just haven't gotten around to making a PR yet - things have been a bit busy this side. I'll make one in the next couple of days.

@lognaturel lognaturel transferred this issue from enketo/enketo-core Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Likely a good issue for a contributor
Projects
None yet
Development

No branches or pull requests

2 participants