Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude more files and folders #61

Closed
wants to merge 1 commit into from
Closed

Exclude more files and folders #61

wants to merge 1 commit into from

Conversation

simonschaufi
Copy link

No description provided.

@simonschaufi
Copy link
Author

if you don't agree with the modifications, please just update the file yourself and remove the lines that you don't want.

@paras-malhotra
Copy link
Member

Thanks for your contribution but this package won't function properly with your suggested changes.

The stubs directory and phpstan.neon are required in the archive. If they're ignored in the archive, all PHPStan checks/analyzers will stop working. Also, the psalm.xml.dist file doesn't exist. So, I'm closing this pull request.

@simonschaufi simonschaufi deleted the patch-1 branch March 31, 2021 06:55
@simonschaufi
Copy link
Author

ok. I made a fulltext search for the stubs folder and didn't find it in the src folder. I didn't change the psalm.xml.dist file, it is just shown because of the eol.

@paras-malhotra
Copy link
Member

Stubs are used here:

enlightn/phpstan.neon

Lines 19 to 20 in cab8edd

stubFiles:
- stubs/Request.stub

The phpstan.neon file is used here:

enlightn/src/PHPStan.php

Lines 96 to 116 in cab8edd

/**
* Run the PHPStan analysis and get the output
*
* @param string|array $paths
* @param string|null $configPath
* @return $this
*/
public function start($paths, $configPath = null)
{
$configPath = $configPath ?? $this->configPath ?? (__DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'phpstan.neon');
$options = ['analyse', '--configuration='.$configPath, '--error-format=json', '--no-progress'];
foreach (Arr::wrap($paths) as $path) {
$options[] = $path;
}
$this->result = json_decode($this->runCommand($options, false), true);
return $this;
}

Hope this clarifies :)

@simonschaufi
Copy link
Author

yes, thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants