Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE should default produce <div> wrappers for text, but <p> #4906

Closed
Bellfalasch opened this issue May 5, 2017 · 0 comments
Closed

TinyMCE should default produce <div> wrappers for text, but <p> #4906

Bellfalasch opened this issue May 5, 2017 · 0 comments
Assignees
Milestone

Comments

@Bellfalasch
Copy link
Contributor

W3C proper semantic HTML for text (paragraphs) is <p>. In 6.10 we wrap paragraphs in <div>. This is un-semantic. Also, I can't think of any site that doesn't expect <p> tags to come out for text. So they style them with CSS, which now breaks in 6.10.

All these commonly used styles breaks:

p {
font-size: 1.2rem;
margin: 1.2rem 0.8rem;
}

and

.news-content p {
color: #808080;
}

This worked in < 6.10 but breaks after upgrading and creates new content. I'm pretty sure issues around this is bound to come in pretty soon.

See how TinyMCE does it - default <p>:
https://www.tinymce.com/

We had huge problems at a custom course at a client to get any text looking right in 6.10. It worked fine in 6.9. I had to update app code to style <div> elements to make it work. But since it is the wrong semantic element for paragraphs it doesn't make sense to hack my CSS like so.

https://developer.mozilla.org/en/docs/Web/HTML/Element/p

If they now are <div> because of some pasting issues we need to solve that pasting somehow different, or perhaps refer to limitations in TinyMCE and live with pasting issues? IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants