Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Button not injected when requiresAuth is true #16

Open
heavydetail opened this issue Aug 7, 2018 · 4 comments
Open

Edit Button not injected when requiresAuth is true #16

heavydetail opened this issue Aug 7, 2018 · 4 comments

Comments

@heavydetail
Copy link

heavydetail commented Aug 7, 2018

Hi,
I am on FF 62.0b10 (64-bit) + Grav v1.5.0-rc.1 + Admin v1.8.7 + Learn2 git sync + nginx-ee 1.10.1 + deb9 + php5-fpm

Issue
The edit button only shows up when requiresAuth is off.

Something about authentication checking is not working on my setup.
Tried to look into it but its too complicated for me since I dont fully understand the Auth lifecycle of Grav.
The processed content (source) doesn't show an inserted frontend-edit-button class, so it is not being inserted and thus it is not a styling issue.

@paulhibbitts
Copy link
Contributor

paulhibbitts commented Sep 2, 2018

Hi @heavydetail , I had similar issues but I discovered that if I enabled Auth required, saved settings, logged out, and then logged back it things worked as expected - might this help you too?

@enovision
Copy link
Owner

Can this issue be closed? Version 1.0.12.1 should resolve this issue.

@heavydetail
Copy link
Author

heavydetail commented Oct 30, 2018

Hi,
in the latest version v1.0.12.1 the edit button is not injected at all now. :/
Same setup as in the first post, except grav updated to Grav v1.6.0-beta.4 - Admin v1.9.0-beta.4
I am not sure if it is a general problem now or something in the admincookie check prevents it from being injected.

edit: I have noticed that the path ->addCss('plugin://frontend-edit-button/assets/css/style.min.css'); does not exist and reverted to /assets/styles.css but it is still not working.

@heavydetail
Copy link
Author

Something with the CSS files is wrong in this version.

When I change that above CSS line to
->addCss('plugin://frontend-edit-button/assets/css-compiled/style.css');
the button appears with text, but no icon.

The top,bottom,left,right classes are otherwise not added and the button disappears.

I can live with this for now, you should fix it in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants