Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes not found error after upgrading to Rails 6.0 from Rails 5.1 #243

Closed
mubarik opened this issue May 14, 2021 · 4 comments
Closed

Routes not found error after upgrading to Rails 6.0 from Rails 5.1 #243

mubarik opened this issue May 14, 2021 · 4 comments

Comments

@mubarik
Copy link

mubarik commented May 14, 2021

Hi ,

Route translator not working after upgrading from Rails 5.1 to Rails 6.0. We are getting routes not found error for the routes in localized block. If we remove those routes from localized block they start working. I checked Rake routes and i can see the routes registered in Journey Routes.

@tagliala
Copy link
Collaborator

Hi, please fill in the bug report: https://github.com/enriclluelles/route_translator/issues/new?assignees=&labels=&template=bug_report.md&title=

A repo with a reproducible test case would help in debugging this issue

@tagliala
Copy link
Collaborator

tagliala commented May 14, 2021

...but before, I think this also includes an upgrade from Route Translator 6 to >= 7.0

From the changelog of Route Translator 7:

[FEATURE] Do not set locale from url by default

And the readme does not contain the proper instructions for 7.0, so please check that your application controller (or the controller you want to translate) contains around_action set_locale_from_url.

This is noted here: https://github.com/enriclluelles/route_translator/blob/master/UPGRADING.md

@mubarik
Copy link
Author

mubarik commented May 20, 2021

Thank you. Issue is resolved. I was upgraded to route_translator 10 . By shifting back to route_translator 7.0. It resolved the issue

@mubarik mubarik closed this as completed May 20, 2021
@tagliala
Copy link
Collaborator

I was upgraded to route_translator 10 . By shifting back to route_translator 7.0. It resolved the issue

Hi, actually your application should be able to use route_translator 10 without issues. The second breaking change that you can read about in https://github.com/enriclluelles/route_translator/blob/master/UPGRADING.md is related to the host configuration

Downgrading to 7.0, which include the breaking change, is just a workaround

Anyway, I can't help without a proper report and a reproducible test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants