You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I believe the CoinType values for some EVM chains are being incorrectly computed from their chainId instead of their Slip44 id
EIP 2304 specifies that the Slip44 Cointype value should be used to index chain's addresses. However in #322 and #326 some Slip44 values were changed to chainIds, causing the convertEVMChainIdToCoinType utility to compute incorrect values for the Cointypes.
For example, the computed value for Celo is 2147525868 (0x8000a4ec) when it should be 52752 (0x8000ce10).
Unfortunately, I'm not sure if there's an easy way to fix. I assume that changing the way CoinTypes are calculated in this lib would effectively invalidate all the existing records. Maybe I'm missing something?
The text was updated successfully, but these errors were encountered:
Was the change to these new cointypes intentional? And should this be documented somewhere?
For context, I encountered this when trying to use Ethers.js to resolve an address. I expect others will run into issues when trying to find the cointype for evm chains if they're using any lib other than this one.
Hi, I believe the CoinType values for some EVM chains are being incorrectly computed from their chainId instead of their Slip44 id
EIP 2304 specifies that the Slip44 Cointype value should be used to index chain's addresses. However in #322 and #326 some Slip44 values were changed to chainIds, causing the convertEVMChainIdToCoinType utility to compute incorrect values for the Cointypes.
For example, the computed value for Celo is 2147525868 (0x8000a4ec) when it should be 52752 (0x8000ce10).
Unfortunately, I'm not sure if there's an easy way to fix. I assume that changing the way CoinTypes are calculated in this lib would effectively invalidate all the existing records. Maybe I'm missing something?
The text was updated successfully, but these errors were encountered: