Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local deployment #30

Open
gfyrag opened this issue Aug 16, 2021 · 4 comments
Open

Local deployment #30

gfyrag opened this issue Aug 16, 2021 · 4 comments

Comments

@gfyrag
Copy link

gfyrag commented Aug 16, 2021

Hello,
i'm trying to deploy ens contracts (registry and one resolver only) and configure use ens-subgraph to index domains.
After registering domains using the registry and the resolver, domains are properly registered but with wrong name (and labelName).
It use the form with the label as hex string.
Digging in the code, i found :

export function handleNameChanged(event: NameChangedEvent): void {
  if(event.params.name.indexOf("\u0000") != -1) return;

  let resolverEvent = new NameChanged(createEventID(event))
  resolverEvent.resolver = createResolverID(event.params.node, event.address)
  resolverEvent.blockNumber = event.block.number.toI32()
  resolverEvent.transactionID = event.transaction.hash
  resolverEvent.name = event.params.name
  resolverEvent.save()
}

Is there a reason to not update the domain name and labelName at this point?

@Arachnid
Copy link
Member

NameChanged is the event triggered for setting reverse records. We don't currently use the name in there to populate preimages for forward resolution, but we could. Would you be happy to submit a PR?

@gfyrag
Copy link
Author

gfyrag commented Aug 20, 2021

Hello,
thks for the response.
If justified, i could make a PR.
Maybe i'm doing things wrong.
Without modification, is there a way to populate name/labelName fields using only the registry and a unique resolver?
The code seems to show than these fields are populate at the "domain creation" and never after that. The pb is than the name is not set at the resolver level at this point.
The code use the function "ens.nameByHash()" but i cannot find concrete implementation. What this function is supposed to do?

Thks for advance for explanations.

@Arachnid
Copy link
Member

The hosted version of the graph has a preimage database that's accessible via nameByHash, which contains many 'well known' names. I don't think they distribute it with the self-hosted version.

At the moment the only way to ensure plaintext names show up would be to also deploy the .eth registrar for your TLD, since the subgraph indexes those events to find labels.

@OkekeChristian24
Copy link

OkekeChristian24 commented Mar 15, 2023

Hello @Arachnid, what could be the cause that my subdomains are appearing like this [0xA4534DaeFEEEEE].chris.eth even some of my domains are like 0xA4534DaeFEEEEE].eth

I'm deploying on local. And how do I bypass the end.nameByHash on the Subgraph?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants