Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensime is not a dependency of scala-mode #117

Closed
davidshen84 opened this issue Aug 20, 2016 · 4 comments
Closed

ensime is not a dependency of scala-mode #117

davidshen84 opened this issue Aug 20, 2016 · 4 comments
Labels

Comments

@davidshen84
Copy link

I tried to install scala-mode from MELPA. But I got:

Entering directory `/home/david/.emacs.d/elpa/scala-mode-20160813.304/'
ob-scala.el:27:1:Error: Cannot open load file: no such file or directory, ensime

I have manually install ensime package before installing scala-mode.

My Emacs version is GNU Emacs 24.5.1 (x86_64-unknown-cygwin)

@hvesalai
Copy link
Owner

@reactormonk, @fommil requiring ensime from ob-scala.el should be done so that it fails quietly if ensime it is not present.

(require FEATURE &optional FILENAME NOERROR), i.e. (require ensime "ensime" t)

@hvesalai hvesalai added the Bug label Aug 20, 2016
@reactormonk
Copy link
Contributor

All functionality of this ob-scala depends on ensime. The logic that doesn't hasn't been merged yet.

@fommil
Copy link
Contributor

fommil commented Aug 20, 2016

I understand this is all going to be moved into org mode at some point anyway by @reactormonk and merged with the existing impl (turns out they already had one)

@fommil
Copy link
Contributor

fommil commented Aug 20, 2016

#114

@fommil fommil closed this as completed Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants