Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing toJSON methods #151

Open
sylwiabr opened this issue May 14, 2019 · 0 comments
Open

Add missing toJSON methods #151

sylwiabr opened this issue May 14, 2019 · 0 comments
Labels
Category: Visualisation Library visualisations Change: Non-Breaking No change to the library API Difficulty: Beginner Requires some HS or C++ knowledge, but little codebase familiarity Priority: Low Should be fixed in the medium term Status: Help Wanted Open for community involvement

Comments

@sylwiabr
Copy link
Member

sylwiabr commented May 14, 2019

Summary

toJSON method is called whenever Luna Studio is trying to show visualization for a node. Missing toJSON methods causing errors on a graph.
Zrzut ekranu 2019-05-14 o 09 32 58
The reproduction steps for above:

  1. read the file i.e. the one from Technical Analysis (welcome screen example)
  2. get single column from the data frame (column "Date")
  3. take field from the column header
  4. get type from the Field

Value

Better visualizations on a graph.

Specification

The toJSON methods should be added to all Classes in Dataframes like:

  • Field
  • TypedColumn
  • DataType
  • Schema
  • StringType, Int32Type etc.

Acceptance Criteria & Test Cases

The nodes with this types should have proper and informative visualizations

@sylwiabr sylwiabr added Category: Visualisation Library visualisations Change: Non-Breaking No change to the library API Difficulty: Beginner Requires some HS or C++ knowledge, but little codebase familiarity Priority: Low Should be fixed in the medium term Status: Help Wanted Open for community involvement labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Visualisation Library visualisations Change: Non-Breaking No change to the library API Difficulty: Beginner Requires some HS or C++ knowledge, but little codebase familiarity Priority: Low Should be fixed in the medium term Status: Help Wanted Open for community involvement
Projects
None yet
Development

No branches or pull requests

1 participant