Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbeans Sampler should run in headless environment #4346

Closed
wdanilo opened this issue Feb 5, 2023 · 0 comments
Closed

Netbeans Sampler should run in headless environment #4346

wdanilo opened this issue Feb 5, 2023 · 0 comments
Assignees
Labels
--bug Type: bug p-low Low priority x-profiling

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by Dmitry Bushev.
Original issue is here.


Netbeans sampler library that we're using for profiling the language server does not behave correctly when stopped from the shutdown hook.
Either find a workaround, or try to fix it in the Netbeans repository

How to reproduce

https://gist.github.com/4e6/8013b1d94abe6d930199e4976ec51ca9

Notes

Tracking issue in the Netbeans repo apache/netbeans#4134

Comments:

Thanks for the reproducer. I've just updated the PR-4134 with a working code. Now it is just about convincing the guys to integrate it into NetBeans 14 (to be released by end of May). (jaroslavtulach - May 23, 2022)


**Dmitry Bushev** reports a new **STANDUP** for today (2022-05-23):

Progress: Implemented a workaround in the language server shutdown logic. Now the server shutdown is initiated from the program thread and not from the shutdown hook. This way it does not trigger the issue, and the sampler writes correct data. Updated the PR It should be finished by 2022-05-24.

Next Day: Next day I will be working on the ##182247072 task. Finish testing and merge the PR (Enso Bot - May 23, 2022)


**Dmitry Bushev** reports a new **STANDUP** for today (2022-05-24):

Progress: When started testing found out that the profiling log only contains the output from the runtime. Implemented the printer for centralized logging of profiling messages. Merged the PR It should be finished by 2022-05-24.

Next Day: Next day I will be working on the ##182178245 task. Start working on asynchronous module notifications (Enso Bot - May 24, 2022)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug p-low Low priority x-profiling
Projects
None yet
Development

No branches or pull requests

3 participants