Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate startup performance of LS+engine #5027

Closed
wdanilo opened this issue Feb 5, 2023 · 2 comments
Closed

Investigate startup performance of LS+engine #5027

wdanilo opened this issue Feb 5, 2023 · 2 comments
Assignees
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.


The engine startup is extremely slow.

We need to investigate it:

project-manager --profiling-events-log-path=start.log --profiling-path=start.npss --profiling-time=20

try some experiments, remeasure and schedule a plan of further actions.

Blockers:

#184370589 blocked

Comments:

These two files contain one recorded startup of the engine. They were generated using the PR-4110 logging support. To analyze what is happening during the start, download both files, put them next to each other and open the .npss file in VisualVM. (jaroslavtulach - Feb 1, 2023)


1164ms of 17s wasted in `org.enso.languageserver.search.SuggestionsHandler.org$enso$languageserver$search$SuggestionsHandler$$generateDocumentation` (jaroslavtulach - Feb 1, 2023)
`org.enso.compiler.Compiler.runImportsAndExportsResolution` takes 3s - also because of slow `SerializationManager.deserialize`. (jaroslavtulach - Feb 1, 2023)
1.5s initializing the language context including 600ms in initialization of `PackageManager`:

(jaroslavtulach - Feb 1, 2023)


**Jaroslav Tulach** reports a new **STANDUP** for yesterday (2023-02-02):

Progress: - measuring suggestions

Next Day: Analyzing performance (Enso Bot - Feb 3, 2023)


**Jaroslav Tulach** reports a new **STANDUP** for yesterday (2023-02-03):

Progress: - caching suggestions

Next Day: Analyzing performance (Enso Bot - Feb 4, 2023)


**Jaroslav Tulach** reports a new **STANDUP** for yesterday (2023-02-04):

Progress: - Pre-compute suggestion db prototype & plan: https://www.pivotaltracker.com/n/projects/2539304/stories/184350816

Next Day: Prepare presentation about analyzing performance (Enso Bot - Feb 5, 2023)


@JaroslavTulach
Copy link
Member

Results of startup improvements as of Mar 9 are promising. After integration of #5068 as well as #5568 and #5791 we managed to speed startup (according to our methodology - #5569) from 11s to 8s. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants