Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text/didChange #661

Closed
3 tasks done
iamrecursion opened this issue Feb 21, 2020 · 1 comment
Closed
3 tasks done

Implement text/didChange #661

iamrecursion opened this issue Feb 21, 2020 · 1 comment
Assignees
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints

Comments

@iamrecursion
Copy link
Contributor

Summary

In addition to text/applyEdit (#549), the other key portion of the text editing workflow is the ability for the language server to inform clients about changes. This is both useful for ensuring that multiple clients stay in sync, as well as allowing the language server to perform broader changes to files that the clients have open where necessary.

Value

We can ensure that the clients and the language server stay in sync with regards to their views of the open buffers.

Specification

  • Implement the text/didChange message as specified in the design document.
  • Ensure that when text/applyEdit is successfully applied, all other clients are informed about it by being sent a text/applyEdit.
  • Document any errors that may be associated with this message in the design document.

Acceptance Criteria & Test Cases

  • The above specification has been implemented.
  • The above functionality has been rigorously tested.
@sylwiabr
Copy link
Member

implemented together with #549

@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added -tooling Category: tooling Change: Non-Breaking p-medium Should be completed in the next few sprints labels Jun 23, 2020
@iamrecursion iamrecursion mentioned this issue Jun 24, 2020
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints
Projects
None yet
Development

No branches or pull requests

4 participants