Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text/closeFile #664

Closed
3 tasks done
iamrecursion opened this issue Feb 21, 2020 · 0 comments
Closed
3 tasks done

Implement text/closeFile #664

iamrecursion opened this issue Feb 21, 2020 · 0 comments
Assignees
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints

Comments

@iamrecursion
Copy link
Contributor

Summary

For text files that are able to be edited collaboratively it's very important that the language server knows which of the files are open by which clients. The text/closeFile message is what informs the LS about this.

Value

Knowing which files are open is incredibly important for the purposes of both updating clients on changes and knowing when to read files from disk or from an in-memory representation. This message ensures that the language server can retain a coherent picture of the project.

Specification

  • Implement the text/closeFile message as specified in the design document.
  • This should track which files are open on a per-client basis, and keep them loaded into in-memory buffers.
  • Specify any errors in the design document.

Acceptance Criteria & Test Cases

  • The above specification has been implemented.
  • The features have been rigorously tested.
@iamrecursion iamrecursion changed the title Implement closeFile Implement text/closeFile Feb 21, 2020
@lolczak lolczak assigned lolczak and unassigned 4e6 Mar 6, 2020
@lolczak lolczak closed this as completed Mar 6, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added -tooling Category: tooling Change: Non-Breaking p-medium Should be completed in the next few sprints labels Jun 23, 2020
@iamrecursion iamrecursion mentioned this issue Jun 24, 2020
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints
Projects
None yet
Development

No branches or pull requests

4 participants