Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC WebSocket Server Library #699

Closed
3 tasks
iamrecursion opened this issue Jan 31, 2020 · 0 comments
Closed
3 tasks

JSON-RPC WebSocket Server Library #699

iamrecursion opened this issue Jan 31, 2020 · 0 comments
Assignees
@kustosz
Labels
--breaking Important: a change that will break a public API or user-facing behaviour -tooling Category: tooling p-high Should be completed in the next sprint

Comments

@iamrecursion
Copy link
Contributor

Summary

Having clarified the design for this part of the language server in #465, it is important to implement the new design. However, as the file management component is also planning to talk JSON-RPC, it is important that it be implemented as a reusable component.

Value

We have a reusable component that provides a WebSocket server that can talk JSON-RPC.

Specification

  • Create a standalone library in this repository.
  • Ensure that it is fit-for-purpose for the language server.
  • Test the functionality of the standalone library.

Acceptance Criteria & Test Cases

  • The above spec is complete.
  • The library is well-tested in isolation.
@kustosz kustosz closed this as completed Feb 12, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added -tooling Category: tooling --breaking Important: a change that will break a public API or user-facing behaviour Difficulty: Core Contributor p-high Should be completed in the next sprint labels Jun 23, 2020
This was referenced Jun 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kustosz kustosz

Labels
--breaking Important: a change that will break a public API or user-facing behaviour -tooling Category: tooling p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kustosz @joenash @iamrecursion