Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After changing single leaf in graph, all visualizaitons are reloaded twice #8899

Closed
Tracked by #8745
farmaazon opened this issue Jan 30, 2024 · 3 comments · Fixed by #8893
Closed
Tracked by #8745

After changing single leaf in graph, all visualizaitons are reloaded twice #8899

farmaazon opened this issue Jan 30, 2024 · 3 comments · Fixed by #8893
Assignees
Labels
--bug Type: bug --low-performance -gui p-medium Should be completed in the next few sprints

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Jan 30, 2024

In the project below, after changing the leaf at on the left (using numeric input), all visualizations are invalidated and reloaded. Then, after zooming/panning, all visualizations are reloaded again.

Bookclub_17_01.zip

@farmaazon farmaazon added --bug Type: bug --low-performance triage -gui p-medium Should be completed in the next few sprints labels Jan 30, 2024
@farmaazon
Copy link
Contributor Author

It seems to be an IDE's fault. Seemingly, we re-attach every visualization on any AST change.

@farmaazon
Copy link
Contributor Author

The problem is that every node id is changed on the widget change (and then again, without my interaction - perhaps some pingback from y-docs server?)

The regression was introduced in a04385a - before we kept the nodes, and no visualization was re-attached.

@farmaazon farmaazon self-assigned this Jan 31, 2024
@farmaazon farmaazon removed the triage label Jan 31, 2024
@farmaazon
Copy link
Contributor Author

The problem seems to be already fixed on #8893

Let's merge it asap, then!

@farmaazon farmaazon linked a pull request Jan 31, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --low-performance -gui p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant