Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments without value set should be hidden on components. #9208

Closed
AdRiley opened this issue Feb 28, 2024 · 4 comments · Fixed by #9246
Closed

Arguments without value set should be hidden on components. #9208

AdRiley opened this issue Feb 28, 2024 · 4 comments · Fixed by #9246
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2024

Components with arguments without value set should generally have those arguments hidden.

image

Unless:

  • Only one component is selected. Then all values/widgets are shown.
    image

  • Some values are marked by libs team as always show. This needs to be respected.

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Feb 28, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 28, 2024
@farmaazon
Copy link
Contributor

If I guess correctly, "default values" are in fact "arguments without value set, which have a default"?

Or should we hide also arguments which have been set to a value equal to the default value of given parameter?

@AdRiley AdRiley changed the title Default values should be hidden on components. Arguments without value set should be hidden on components. Feb 28, 2024
@AdRiley
Copy link
Member Author

AdRiley commented Feb 28, 2024

Yes thank you. Arguments without value set. I don't think actually if they have a default or not makes a difference.

I think that what you see in the code editor should be the same as you see on the graph. So for the above example

image

@farmaazon
Copy link
Contributor

Yes thank you. Arguments without value set. I don't think actually if they have a default or not makes a difference.

I think it makes. We will display all ports which have to be connected by the user to make component functioning properly.

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints labels Feb 29, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Feb 29, 2024

Refinement notes:

  • We hide every placeholder (widget without value set) which is an argument with default value
  • Display parameter of widget configuration should override above.
  • A node should be extended only when it's the only node selected.
  • When during box selecting, no node should be extended (or shrunk) before finishing drag.
  • We keep displaying unset arguments which have no default value (to inform user about arguments they have to provide).
  • Extending it tied to showing circular menu (show both or none).
  • Add extending animation if it will be easy.

@kazcw kazcw self-assigned this Mar 1, 2024
@kazcw kazcw mentioned this issue Mar 1, 2024
5 tasks
@kazcw kazcw linked a pull request Mar 4, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants