Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the LS to Support Multiple Content Roots #1800

Merged
merged 8 commits into from Jun 16, 2021
Merged

Refactor the LS to Support Multiple Content Roots #1800

merged 8 commits into from Jun 16, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Does what it says on the tin.

Important Notes

This introduces a breaking change for the IDE as the "content root" is now a rich structure instead of just a UUID.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Jun 15, 2021
@iamrecursion iamrecursion requested a review from 4e6 June 15, 2021 11:47
@iamrecursion iamrecursion self-assigned this Jun 15, 2021
@iamrecursion iamrecursion marked this pull request as ready for review June 15, 2021 13:19
@iamrecursion iamrecursion merged commit af4558a into main Jun 16, 2021
@iamrecursion iamrecursion deleted the wip/ara/multiple-roots branch June 16, 2021 10:00
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Refactor the LS to support multiple content roots (#1800)
ed84cde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamrecursion @4e6