Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_deselected not emitted from graph editor frp outputs #3007

Closed
mwu-tow opened this issue Jun 14, 2021 · 3 comments
Closed

node_deselected not emitted from graph editor frp outputs #3007

mwu-tow opened this issue Jun 14, 2021 · 3 comments
Assignees
@MichaelMauderer

Comments

@mwu-tow
Copy link
Contributor

mwu-tow commented Jun 14, 2021

Start IDE with an empty project. Click on the node. Click on the background.

When I click on the node, it is selected and node_selected is emitted. However, when I clear selection by clicking on the background node_deselected signal is missing.

node_deselected seems to be emitted only when using area selection.

This seems to have regressed in db31134558fd65ff219b597910411c01c8691603
@mwu-tow
Copy link
Contributor Author

mwu-tow commented Jun 29, 2021

This is not fixed.

@mwu-tow mwu-tow reopened this Jun 29, 2021
@MichaelMauderer
Copy link
Contributor

@mwu-tow Can you check whether this is still happening on the newest develop?

@mwu-tow
Copy link
Contributor Author

mwu-tow commented Jul 8, 2021

It is fixed! 👍

@mwu-tow mwu-tow closed this as completed Jul 8, 2021
@mwu-tow mwu-tow transferred this issue from enso-org/ide Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelMauderer MichaelMauderer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichaelMauderer @mwu-tow @sylwiabr