Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS - Hide the contents in recent apps when lockscreen is set #47

Closed
mnvr opened this issue Jan 29, 2023 · 4 comments · Fixed by #387
Closed

iOS - Hide the contents in recent apps when lockscreen is set #47

mnvr opened this issue Jan 29, 2023 · 4 comments · Fixed by #387
Labels
- auth Relates to Ente Auth

Comments

@mnvr
Copy link
Member

mnvr commented Jan 29, 2023

Feature request via email

After I set Lockscreen, and I swipe up the auth app (iPhone), the contents of the app can be seen like many other apps except password manager (set lockscreen). Like password manager, can the contents be hidden when Lockscreen is set?
@fr-gg
Copy link

fr-gg commented Apr 5, 2023

Android also has this issue

@ashutoshsaboo
Copy link

ashutoshsaboo commented Apr 8, 2023 •
edited

+1 on this for ios, for an auth app consisting of secrets data - this is kind of a security issue.

@ashutoshsaboo
Copy link

ashutoshsaboo commented May 15, 2023 •
edited

Bumping this up. @vishnukvmd @ua741 , is this on the near term plans - almost all apps including bitwarden and many others do this, so pretty sure both ios/android support for this (feel free to correct me)? It's kind of a security issue otherwise.

@emikaadeo-git
Copy link

+1 for iOS

@i-aiymen i-aiymen mentioned this issue Dec 5, 2023
Merged
8 tasks
vishnukvmd pushed a commit that referenced this issue Dec 6, 2023
@i-aiymen
Added: When the app is in the background, hided te contents of the app (
1a654fe 
#387)

<!--
  Thanks for contributing!

Provide a description of your changes below and a general summary in the
title

Please look at the following checklist to ensure that your PR can be
accepted quickly:
-->

## Description

Added: Hide the contents of the app, when is it in the background - Both
android and ios

In android, it shows a blank white/black background, when in background

In iOS, it shows the launch icon, when in background


![photo_2023-12-06_12-53-02](https://github.com/ente-io/auth/assets/54765537/4f787e6a-984c-4eae-9028-303a32009838)

Android Physical Device


![photo_2023-12-06_12-52-55](https://github.com/ente-io/auth/assets/54765537/b8802cf5-0db0-473e-8be8-8cf3bf7b29a5)

Android stimulator

Also, compared the bitwarden apps in android, the flow is same

iOS Device: Need to verify 
@ua741 @vishnukvmd Could you run on iOS devices and verify it?

Closes #47 

## Type of Change

<!--- Put an `x` in all the boxes that apply: -->

- [ ] 🖼️ New icon
- [x] ✨ New feature (non-breaking change which adds functionality)
- [ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [ ] 📝 Documentation
- [ ] 🗑️ Chore
@mnvr mnvr added the - auth Relates to Ente Auth label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- auth Relates to Ente Auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added: When the app is in the background, hided te contents of the app ente-io/ente
4 participants
@ashutoshsaboo @mnvr @emikaadeo-git @fr-gg