Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

add live photo upload support #253

Merged
merged 58 commits into from
Feb 16, 2022
Merged

add live photo upload support #253

merged 58 commits into from
Feb 16, 2022

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Nov 26, 2021

Description

^title

Screenshots

image

image

image

Test Plan

  • test the notification toast UI
  • test notification is shown and only three times
  • test local-ids are properly assigned
  • filenames properly set for each file
  • test uploading live photo will asset size greater than 20MB
  • live photo thumbnail generation works and HEIC images are detected properly
  • check clustering for different cases
  • 1. all live photos
  • 2. no live photos
  • 3. mix of live photos and normal photos
  • 4. live photos are sorted at the begin
  • 5. live photos are at the end
  • 6. normal photos between live photos pairs
  • 7. same name two image files and two video files
  • handle underscore suffix case
  • 1. file name has more than one underscore
  • file uploaded to the right collection
  • file count shown correctly
  • move to upload result list works correctly
  • check upload progress showed correctly

@abhinavkgrd abhinavkgrd marked this pull request as draft November 26, 2021 10:47
@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 26, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 671bf0e
Status: ✅  Deploy successful!
Preview URL: https://d331a5e4.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd changed the base branch from master to refactor-metadata-extraction-v2 February 13, 2022 07:30
@abhinavkgrd abhinavkgrd changed the base branch from refactor-metadata-extraction-v2 to master February 13, 2022 11:00
@abhinavkgrd abhinavkgrd marked this pull request as ready for review February 13, 2022 11:00
src/services/upload/livePhotoService.ts Outdated Show resolved Hide resolved
src/services/upload/livePhotoService.ts Outdated Show resolved Hide resolved
src/services/upload/livePhotoService.ts Outdated Show resolved Hide resolved
ua741
ua741 previously approved these changes Feb 15, 2022
src/services/upload/livePhotoService.ts Show resolved Hide resolved
src/services/upload/livePhotoService.ts Outdated Show resolved Hide resolved
@abhinavkgrd abhinavkgrd merged commit f7cb51f into master Feb 16, 2022
@abhinavkgrd abhinavkgrd deleted the live-photo-import branch February 16, 2022 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants