This repository has been archived by the owner on May 14, 2024. It is now read-only.
Live photo playback support #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
83c65e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://328cd92b.bada-frame.pages.dev |
|
Looks like this now:
|
abhinavkgrd
reviewed
Feb 26, 2022
|
also, merge the master to this branch. so the network request failing issue is solved. |
abhinavkgrd
reviewed
Feb 28, 2022
abhinavkgrd
reviewed
Feb 28, 2022
|
Looks like this now: ente.io._.encrypted.photo.storage.-.Rushikesh.-.Microsoft.Edge.2022-03-01.18-31-09.mp4 |
abhinavkgrd
reviewed
Mar 1, 2022
|
I updated the fade in and out logic to handle things using CSS transition. if anything confuses you in that feel free to ask |
abhinavkgrd
reviewed
Mar 2, 2022
rushitote
force-pushed
the
add-livephoto-support
branch
from
bfdd3fa
to
5c40812
Compare
|
@rushitote Could you keep the playback button at the bottom right corner? |
|
@vishnukvmd done in latest commit. |
abhinavkgrd
reviewed
Mar 3, 2022
abhinavkgrd
reviewed
Mar 3, 2022
abhinavkgrd
reviewed
Mar 3, 2022
There was a problem hiding this comment.
cools everything looks good to me 😄
will let @vishnukvmd and @ua741 test it once and then will approve it
remove the notification for preview support coming
abhinavkgrd
approved these changes
Mar 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added encoding for live photos using FFMPEG but currently just plays the video file. So, need to find a way to play only on hover and also a loading spinner while the file is downloading/encoding.
Test Plan