Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix heic conversion failing #434

Merged
merged 31 commits into from
Mar 25, 2022
Merged

Fix heic conversion failing #434

merged 31 commits into from
Mar 25, 2022

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Mar 9, 2022

Description

  • add a timeout to HEIC conversion (1 minute)
  • use a worker pool of 2 to give each worker a breathing room
  • libheif is built single-threaded so the earlier five consecutive calls were essentially getting queued internally. so just reduced queue processing to one
  • discard old worker when it errors out and replaces with a new one
  • added retry logic on fail

Test Plan

tested locally that the timeout and conversion is working

… a double the size of that as worker pool also use png as it didn't crash for two parralel files and add a timeout to heic conversion
@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 9, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 66b56d5
Status: ✅  Deploy successful!
Preview URL: https://202984d4.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd changed the title Fix heic convert fail Fix heic conversion hanging Mar 9, 2022
@abhinavkgrd abhinavkgrd requested a review from ua741 March 10, 2022 04:12
@abhinavkgrd abhinavkgrd changed the title Fix heic conversion hanging Fix heic failing Mar 10, 2022
@abhinavkgrd abhinavkgrd changed the title Fix heic failing Fix heic conversion failing Mar 10, 2022
ua741
ua741 previously approved these changes Mar 10, 2022
@abhinavkgrd abhinavkgrd merged commit c580ac6 into master Mar 25, 2022
@abhinavkgrd abhinavkgrd deleted the fix-heic-convert-fail branch April 4, 2022 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants