Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

parseExif by self if exifr return unparsed value #440

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

abhinavkgrd
Copy link
Member

@abhinavkgrd abhinavkgrd commented Mar 11, 2022

Description

exifr function has an option to convert EXIF Format date to date instance, but it's failing sometime and it returns the date without converting which causes the date.getTime() call to fail

added checks to log the date format which are failing and gracefully handle the failure

  • handle cases when exifr date revive fails

Test Plan

tested locally

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 11, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e58a9d
Status: ✅  Deploy successful!
Preview URL: https://fb9ddfbe.bada-frame.pages.dev

View logs

@abhinavkgrd abhinavkgrd changed the base branch from fix-get-exif-fail to master March 11, 2022 14:43
@abhinavkgrd abhinavkgrd merged commit 67ee950 into master Mar 11, 2022
@abhinavkgrd abhinavkgrd deleted the improve-exif-parsing branch April 27, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants