This repository has been archived by the owner on May 14, 2024. It is now read-only.
prevent metadata value from getting cached #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavkgrd
force-pushed
the
fix-metadata-value-getting-cached
branch
from
3a2ca6e
to
895a467
Compare
Deploying with
|
| Latest commit: |
895a467
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf634c21.bada-frame.pages.dev |
ua741
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
so when a property object is assigned to another object, it creates a shallow copy and hence when I edited the
extractedMetadata.creationTime, it also edited the creation time on theNULL_EXTRACTED_METADATAtoo which was used to initialise itfixed it by not editing the value, instead of adding a fallback to the initialisation of creationTime in the response object
Test Plan
tested locally by trying to upload multiple files with no EXIF data but having DateTime in the filename so that the issue would get triggered but it didn't occur. All is good